Repository navigation
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
ST-DDT
added
c: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4254 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 1179 1179
Lines 3976 3976
Branches 709 709
=======================================
Hits 3942 3942
Misses 29 29
Partials 5 5
🚀 New features to boost your workflow:
|
|
Requesting team decision regarding this feature. |
|
I measured compiler overhead against this PR's base using TypeScript 6.0.3. Full-project median total was 6.095s on base versus 6.165s on the original PR, with overlapping timing ranges; instantiations rose from 142,409 to 154,495. A 100-call typical consumer took 0.48s versus 0.53s, and a deliberately heavy 1,010-call fixture took 0.84s versus 1.10s. The cap bounds recursion but doesn't make it free. I've split the helper so count guards run once rather than at every recursion step. In the stress fixture, instantiations fell from 108,285 to 48,008; total time changed from 1.10s to 1.07s. This is not evidence of a large speedup or a whole-project speedup. Build, typecheck and 857 date tests pass. Two full-suite Markdown snapshot failures also reproduce on the unchanged PR head in this environment. These are one-host, one-compiler measurements, not editor or downstream-project guarantees. The API scope and cap are unchanged. |
Explicit integer counts from 0 to 100 now infer date tuples, so strict callers can destructure a known number of dates without possibly-undefined values. Omitted, optional, ranged, dynamic and larger counts keep Date[]. Runtime generation is unchanged.
Refs #3407. The cap bounds recursive type expansion and is open to maintainer feedback.
AI-assisted patch. Manav selected this issue; human code review is pending. Build, typecheck and tests pass. Full project lint aborts locally in oxlint 1.90.0 with the JS JSDoc plugin enabled, including on an unchanged file; native-only checks pass but do not replace that check.